Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269Ab1EYW1O (ORCPT ); Wed, 25 May 2011 18:27:14 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:14246 "EHLO ironport2-out.pppoe.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754275Ab1EYW1N (ORCPT ); Wed, 25 May 2011 18:27:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApIBABqB3U1Ld/sX/2dsb2JhbAAMhFDXc5BZgSuDaoEHBJdkh24 X-IronPort-AV: E=Sophos;i="4.65,269,1304308800"; d="scan'208";a="114678412" Message-ID: <4DDD823F.5090904@teksavvy.com> Date: Wed, 25 May 2011 18:27:11 -0400 From: Mark Lord User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Bruce Stenning CC: Tejun Heo , "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" Subject: Re: sata_mv port lockup on hotplug (kernel 2.6.38.2) References: <20110423005610.GC1576@mtj.dyndns.org> <20110425162242.GB30828@mtj.dyndns.org> <20110426135027.GI878@htj.dyndns.org> <20110426155229.GM878@htj.dyndns.org> <20110430140109.GJ29280@htj.dyndns.org> <20110525094127.GF10146@htj.dyndns.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 23 On 11-05-25 09:36 AM, Bruce Stenning wrote: >> This is a different issue. libata EH plugs the port if reset fails >> repeatedly. This behavior was implemented to avoid causing continuous >> resets on a port in case it has flaky PHY state reporting; however, it >> seems to cause more trouble than fixing issues - ie. plugging in a >> broken device may end up plugging the port even after the offending >> device is removed until manual rescan or reboot. I've been pondering >> about changing the behavior like the following. > > Thanks for the explanation, Tejun, and for sending those changes upstream. > I shall incorporate these patches into my kernel and keep you informed as > to how they behave. > > Mark, did you get a chance to clean up the sata_mv spinlock addition in > mv_set_main_irq_mask? Not yet. I've been waiting to hear back from you as to whether they visibly fix anything or not. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/