Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756581Ab1EYXPU (ORCPT ); Wed, 25 May 2011 19:15:20 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49442 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754299Ab1EYXPR (ORCPT ); Wed, 25 May 2011 19:15:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <4DDB8BF6.2000304@fusionio.com> <4DDCB1C8.7040708@fusionio.com> <4DDD5240.2060308@fusionio.com> <4DDD55D6.1080909@fusionio.com> <1306356735.1641.61.camel@mulgrave.site> From: Linus Torvalds Date: Wed, 25 May 2011 16:14:52 -0700 Message-ID: Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] To: Parag Warudkar Cc: James Bottomley , Jens Axboe , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , Linux SCSI List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 26 On Wed, May 25, 2011 at 4:00 PM, Parag Warudkar wrote: > > It doesn't seem to help. Machine locked up and I was dropped to text > console. I could only capture the oops by a camera. Hmm. That's a different oops. It is now in scsi_prep_state_check(). At the beginning of it too. You can't see the "Code: " line in the pictures, but the only dereference I see there is "sdev" itself being NULL. And %cr2 is 0x640, which would seem to agree (the 'sdev' structure is absolutely disgustingly big, and sdev->sdev_state is indeed at an offset in that region. That 'sdev' comes from scsi_prep_fn() doing struct scsi_device *sdev = q->queuedata; is that queuedata perhaps cleared even if the queue itself stays around due to refcounts? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/