Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258Ab1EZBY6 (ORCPT ); Wed, 25 May 2011 21:24:58 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:31875 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500Ab1EZBY5 (ORCPT ); Wed, 25 May 2011 21:24:57 -0400 From: "Tomoya MORINAGA" To: "'Alexander Stein'" Cc: "'Grant Likely'" , , , , , , , "'Fan, Yongning'" References: <1304938729-10609-1-git-send-email-tomoya-linux@dsn.okisemi.com> <201105251409.47309.alexander.stein@systec-electronic.com> Subject: RE: pch_gpio: Support new device ML7223 Date: Thu, 26 May 2011 10:24:55 +0900 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: Acwa1KWQ8HqXg8uoQ/qPIGVFrpsyywAbS3tw In-Reply-To: <201105251409.47309.alexander.stein@systec-electronic.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1070 Lines: 32 > From: Alexander Stein [mailto:alexander.stein@systec-electronic.com] > Sent: Wednesday, May 25, 2011 9:10 PM > > #define pch_gpio_resume NULL #endif > > > > +#define PCI_VENDOR_ID_ROHM 0x10DB > > Should this be moved to pci_ids.h? OK. I will move this to pci_ids.h. > > > static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = { > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) }, > > + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) }, > > Likewise for the product ID. While at it, the ID for EG20T > could also be moved in a separate patch. We have already upstreamed not only GPIO but also many device drivers(GBE, USBDEV,DMA,UART,SPI,I2C,CAN). Do you mean we must move these device definitions to pci_ids.h? Thanks, ----------------------------------------- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/