Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755763Ab1EZF0M (ORCPT ); Thu, 26 May 2011 01:26:12 -0400 Received: from mail.bluewatersys.com ([202.124.120.130]:41916 "EHLO hayes.bluewaternz.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754477Ab1EZF0J (ORCPT ); Thu, 26 May 2011 01:26:09 -0400 Message-ID: <4DDDE469.2020502@bluewatersys.com> Date: Thu, 26 May 2011 17:26:01 +1200 From: Ryan Mallon Reply-To: rmallon@gmail.com User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Mika Westerberg CC: Linus Walleij , linux-arm-kernel@lists.infradead.org, Vinod Koul , linux-kernel@vger.kernel.org, hsweeten@visionengravers.com, Dan Williams , Grant Likely , spi mailing list Subject: Re: [PATCH 1/5] dmaengine: add ep93xx DMA support References: <20110525195413.GC2996@acer> <20110526043344.GA2749@acer> In-Reply-To: <20110526043344.GA2749@acer> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 37 On 26/05/11 16:33, Mika Westerberg wrote: > On Wed, May 25, 2011 at 10:47:14PM +0200, Linus Walleij wrote: >> >>> IMHO it is better to have ep93xx implementation on its own driver since it is >>> not a real AMBA PL022 peripheral but some weird hack made by Cirrus (although >>> my opinions are bit biased). >> >> I disagree because it's IMO at first sight no more deviant than our "PL023" >> variants that still use the same pl022 driver. > > Ok. > > Do you think that we can go forward with this patch series if I drop the last > patch (spi/ep93xx: add DMA support)? This way we will have dmaengine > implementation in place, whatever SPI driver we choose to use with ep93xx. > > We can then try to use amba-pl022 driver with ep93xx and see if it works or > not, and how much work is needed. I would like some comments from Hartley and > Ryan also. I think if we can modify the amba-pl022 driver, without it turning into a mess, then we should do that. The ep93xx doesn't really see much attention, so sharing the code base wherever possible should hopefully get better review and testing. The rest of the patch series is fine by me. You can have my Acked-by: Ryan Mallon for the ep93xx core and old dma implementation removal parts. ~Ryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/