Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535Ab1EZMcG (ORCPT ); Thu, 26 May 2011 08:32:06 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:56013 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757518Ab1EZMcB (ORCPT ); Thu, 26 May 2011 08:32:01 -0400 Date: Thu, 26 May 2011 14:31:53 +0200 From: Ingo Molnar To: Joe Perches Cc: Ben Greear , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, "David S. Miller" , Arnd Bergmann , netdev@vger.kernel.org Subject: [patch] net/core/filter.c: Fix build error Message-ID: <20110526123153.GA16002@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 70 * Joe Perches wrote: > A mis-configured filter can spam the logs with lots of stack traces. > > Rate-limit the warnings and add printout of the bogus filter information. > > Original-patch-by: Ben Greear > Signed-off-by: Joe Perches > --- > net/core/filter.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 0eb8c44..0e3622f 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -350,7 +350,9 @@ load_b: > continue; > } > default: > - WARN_ON(1); > + WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u k:%u\n", > + fentry->code, fentry->jt, > + fentry->jf, fentry->k); > return 0; > } This change (now upstream) fails to build in about 20% of all randconfigs. Fix is below. Thanks, Ingo ---------------------> >From b658026bc4915d16ff3e0f59b0edda11dbd6b991 Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Thu, 26 May 2011 14:11:14 +0200 Subject: [PATCH] net/core/filter.c: Fix build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix: net/core/filter.c:353:4: error: invalid storage class for function ‘DEFINE_RATELIMIT_STATE’ Signed-off-by: Ingo Molnar --- net/core/filter.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index 0e3622f..36f975f 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -38,6 +38,7 @@ #include #include #include +#include /* No hurry in this branch */ static void *__load_pointer(const struct sk_buff *skb, int k, unsigned int size) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/