DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=WMnUIduw2ayu5pYx2n+U2mRJW/L0tntjTGZZ6enhyiinPpPoi7+D7adsAx4J0vyNcu
         RVMDrOgVvdVKFWJ5U2vAq1Xe7xjG2iT0guvVzyFZe5fMkxYZUKEIwUg703D/L1PxkPYr
         JaQksFg7i4o4pDq1QMnHTUAE1nTyQiqMdqVkQ=
MIME-Version: 1.0
In-Reply-To: <4DDE58E9.1050307@canonical.com>
References: <20110519182702.GA3337@maxin>
	<4DDCFA6F.2020801@canonical.com>
	<BANLkTinaVB-Y3kVzU9vHYUJs5P7Ea_JhOg@mail.gmail.com>
	<4DDE58E9.1050307@canonical.com>
Date: Thu, 26 May 2011 16:31:27 +0100
Message-ID: <BANLkTimOkpfLSiHp0Dm+jxxtHfA3PSVG-A@mail.gmail.com>
Subject: Re: [PATCH] drivers: video: Remove useless checks
From: Maxin B John <maxin.john@gmail.com>
To: tim.gardner@canonical.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        airlied@redhat.com, lethal@linux-sh.org, james@albanarts.com,
        error27@gmail.com, randy.dunlap@oracle.com
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 716
Lines: 21

Hi,

> IMHO mixing signed and unsigned comparisons like this is just wrong. Its
> unnecessarily complicated and misleading, especially for a device driver.

Yes. I do agree with you.

> Its likely that the reason the fb code got into this situation is because a
> type was changed from signed to unsigned whence long ago, and nobody has
> bothered to clean it up.

Thats possible. Similar useless checks are present in other subsystems
of the kernel as well.

WBR,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/