Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758243Ab1EZSI4 (ORCPT ); Thu, 26 May 2011 14:08:56 -0400 Received: from mail.us.es ([193.147.175.20]:47682 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758096Ab1EZSIy (ORCPT ); Thu, 26 May 2011 14:08:54 -0400 Message-ID: <4DDE9730.3050405@netfilter.org> Date: Thu, 26 May 2011 20:08:48 +0200 From: Pablo Neira Ayuso User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20110506 Icedove/3.0.11 MIME-Version: 1.0 To: Eric Dumazet CC: Kevin Cernekee , Patrick McHardy , "David S. Miller" , netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 resend] netfilter: nf_conntrack_sip: Handle Cisco 7941/7945 IP phones References: <4DDE84F2.7080706@netfilter.org> <1306432664.2543.2.camel@edumazet-laptop> In-Reply-To: <1306432664.2543.2.camel@edumazet-laptop> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 48 On 26/05/11 19:57, Eric Dumazet wrote: > Le jeudi 26 mai 2011 à 18:50 +0200, Pablo Neira Ayuso a écrit : >> Hi Eric, >> >> On 20/05/11 06:36, Kevin Cernekee wrote: >>> Most SIP devices use a source port of 5060/udp on SIP requests, so the >>> response automatically comes back to port 5060: >>> >>> phone_ip:5060 -> proxy_ip:5060 REGISTER >>> proxy_ip:5060 -> phone_ip:5060 100 Trying >>> >>> The newer Cisco IP phones, however, use a randomly chosen high source >>> port for the SIP request but expect the response on port 5060: >>> >>> phone_ip:49173 -> proxy_ip:5060 REGISTER >>> proxy_ip:5060 -> phone_ip:5060 100 Trying >>> >>> Standard Linux NAT, with or without nf_nat_sip, will send the reply back >>> to port 49173, not 5060: >>> >>> phone_ip:49173 -> proxy_ip:5060 REGISTER >>> proxy_ip:5060 -> phone_ip:49173 100 Trying >>> >>> But the phone is not listening on 49173, so it will never see the reply. >>> >>> This patch modifies nf_*_sip to work around this quirk by extracting >>> the SIP response port from the Via: header, iff the source IP in the >>> packet header matches the source IP in the SIP request. >>> >>> Signed-off-by: Kevin Cernekee >>> Acked-by: Eric Dumazet >>> Cc: Patrick McHardy >> >> @Eric: could you please confirm that you ack'ed this patch? I don't find >> the email with your explicit ack. > > Yes I did it ;) > > http://www.spinics.net/lists/netfilter/msg49632.html > > Thanks ! OK, applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/