Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933037Ab1EZTBO (ORCPT ); Thu, 26 May 2011 15:01:14 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:45275 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780Ab1EZTBL (ORCPT ); Thu, 26 May 2011 15:01:11 -0400 Date: Thu, 26 May 2011 15:00:57 -0400 (EDT) Message-Id: <20110526.150057.165386141746439600.davem@davemloft.net> To: randy.dunlap@oracle.com Cc: joe@perches.com, mingo@elte.hu, greearb@candelatech.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, netdev@vger.kernel.org Subject: Re: [patch] net/core/filter.c: Fix build error From: David Miller In-Reply-To: <20110526115721.ee83aefc.randy.dunlap@oracle.com> References: <1306423866.16087.10.camel@Joe-Laptop> <20110526.143843.205897228685761536.davem@davemloft.net> <20110526115721.ee83aefc.randy.dunlap@oracle.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 26 May 2011 12:00:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 36 From: Randy Dunlap Date: Thu, 26 May 2011 11:57:21 -0700 > On Thu, 26 May 2011 14:38:43 -0400 (EDT) David Miller wrote: > >> From: Joe Perches >> Date: Thu, 26 May 2011 08:31:06 -0700 >> >> > My suggestion would be to see about again adding >> > #include somehow >> > back to kernel.h which commit 3fff4c42bd0a removed >> > in 2009 because of the spinlock issues. >> > >> > Any suggestion on how best to fix it generically? >> >> I don't think we want spinlock_t's definition being sucked >> into kernel.h's dependency food chain. >> >> Even if desirable, I think it'd be quite a bit of surgery, >> too much to do at this stage. >> >> So for now how about we make the ratelimit warn interfaces be a true, >> instead of a pseudo, dependency on ratelimit.h by moving those >> definitions into ratelimit.h? > > Works for me. Thanks. > > Acked-by: Randy Dunlap Thanks for reviewing Randy, I've put this into net-2.6 and will push it out to Linus soon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/