Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758368Ab1EZTNF (ORCPT ); Thu, 26 May 2011 15:13:05 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:58069 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757985Ab1EZTND (ORCPT ); Thu, 26 May 2011 15:13:03 -0400 Date: Thu, 26 May 2011 21:12:56 +0200 From: Ingo Molnar To: David Miller Cc: joe@perches.com, greearb@candelatech.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, netdev@vger.kernel.org Subject: Re: [patch] net/core/filter.c: Fix build error Message-ID: <20110526191256.GA4553@elte.hu> References: <20110526123153.GA16002@elte.hu> <1306423866.16087.10.camel@Joe-Laptop> <20110526.143843.205897228685761536.davem@davemloft.net> <20110526190939.GC3476@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110526190939.GC3476@elte.hu> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 22 * Ingo Molnar wrote: > So no, i don't think your patch is the real solution. [...] s/real/complete Note, your patch solves a real problem: the ratelimited WARN_ON()s should not be in the generic bug.h header, that's just broken. I just don't think this is the only problem: the other problem was what hid the bug in the first place, the spurious ratelimit.h inclusion via net.h. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/