Date: Fri, 27 May 2011 10:00:51 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Tony Luck <tony.luck@gmail.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 07/12] x86, mce: introduce mce_gather_info()
Message-ID: <20110527080051.GB19300@elte.hu>
References: <4DDF21DE.9040705@jp.fujitsu.com>
 <4DDF23F5.1090206@jp.fujitsu.com>
 <BANLkTinCRX3YOXwuphRTBS=OcHuC07a1jw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BANLkTinCRX3YOXwuphRTBS=OcHuC07a1jw@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 906
Lines: 25


* Tony Luck <tony.luck@gmail.com> wrote:

> 2011/5/26 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
> 
> > As the result the mce_get_rip() is integrated and unnecessary 
> > zero-ing is removed. ?This also fix an issue pointed by Tony Luck 
> > that RIP is required to make some decision about error severity 
> > (for SRAR errors) but it was retrieved later in the handler.
> 
> To keep the credit path accurate, that was one of the pieces I 
> picked up from Andi.

At minimum an explanation should be put into the code. Small, hidden 
dependencies might be common job security moves in the closed source 
world but this is open source ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/