DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=DELHVMMGsCEbCD2NR/hbXjQpFZDml2zvlTA/N1qDngKwYUATpGkrB3/9LyZpCdwnw4
         KYh2U6ZgZeM2jzdZAblqWFFMUbCPnVN0KUtlGJVxqlVWCnhUEUXk3AKNi3WnoxA8BwuE
         yjF6qrGI+mmVlnhCMAgX5dv1MtYbt/ayfNjUE=
MIME-Version: 1.0
In-Reply-To: <20110527080051.GB19300@elte.hu>
References: <4DDF21DE.9040705@jp.fujitsu.com>
	<4DDF23F5.1090206@jp.fujitsu.com>
	<BANLkTinCRX3YOXwuphRTBS=OcHuC07a1jw@mail.gmail.com>
	<20110527080051.GB19300@elte.hu>
Date: Fri, 27 May 2011 09:29:20 -0700
Message-ID: <BANLkTimtcXNjzeRM+cX22fUEFZ5stk8Z3g@mail.gmail.com>
Subject: Re: [PATCH 07/12] x86, mce: introduce mce_gather_info()
From: Tony Luck <tony.luck@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 810
Lines: 20

On Fri, May 27, 2011 at 1:00 AM, Ingo Molnar <mingo@elte.hu> wrote:
> At minimum an explanation should be put into the code. Small, hidden
> dependencies might be common job security moves in the closed source
> world but this is open source ;-)

Seto-san,

Perhaps this more descriptive comment for you new mce_gather_info()
function would help:

/*
 * Collect all global (w.r.t. this processor) status about this machine
 * check into our "mce" struct so that we can use it later to assess
 * the severity of the problem as we read per-bank specific details.
 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/