Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980Ab1E0TIQ (ORCPT ); Fri, 27 May 2011 15:08:16 -0400 Received: from mail.perches.com ([173.55.12.10]:2139 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab1E0TIK (ORCPT ); Fri, 27 May 2011 15:08:10 -0400 Subject: Re: [patch v4] checkpatch: Signature format verification From: Joe Perches To: Manish Kumar Singh Cc: anish , davej@redhat.com, rostedt@goodmis.org, apw@shadowen.org, akpm@linux-foundation.org, vapier@gentoo.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1306006721.1622.18.camel@anish-desktop> <1306059528.2761.3.camel@anish-desktop> <1306164094.2292.25.camel@anish-desktop> <1306519311.1918.12.camel@anish-desktop> <1306520991.31864.9.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 27 May 2011 12:08:08 -0700 Message-ID: <1306523288.31864.29.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 31 On Sat, 2011-05-28 at 00:28 +0530, Manish Kumar Singh wrote: > On Fri, May 27, 2011 at 11:59 PM, Joe Perches wrote: [] > 8 bit chars, digits? > What is 8 bit char...could you describe it? An ascii char with the high order bit set. Any char from 128 to 255. [] > For the 3rd time, please use this form: > if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) { > and if you really want email format validation, > use a separate function. [] > Problem with your way of doing is if anyone misses space between > "sign" & name, > the regular expression (/^(\s*)($ValidSignatures)(\s*)(.*)$/i ) > doesn't match That's incorrect. Try it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/