Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757489Ab1E0Wz1 (ORCPT ); Fri, 27 May 2011 18:55:27 -0400 Received: from mga09.intel.com ([134.134.136.24]:63407 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757313Ab1E0WzB (ORCPT ); Fri, 27 May 2011 18:55:01 -0400 X-ExtLoop1: 1 From: Andi Kleen To: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, Andi Kleen , dchinner@redhat.com, aelder@sgi.com Subject: [PATCH 4/4] XFS: Set NOSEC flag early when inode has no xattrs. Date: Fri, 27 May 2011 15:54:05 -0700 Message-Id: <1306536845-24162-4-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1306536845-24162-1-git-send-email-andi@firstfloor.org> References: <1306536845-24162-1-git-send-email-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 61 From: Andi Kleen Set the S_NOSEC flag early if the inode has no xattrs for XFS. This avoids a single xattr lookup for the first write on every file, if the file has no xattrs. Cc: dchinner@redhat.com Cc: aelder@sgi.com Signed-off-by: Andi Kleen --- fs/xfs/linux-2.6/xfs_iops.c | 3 +++ fs/xfs/xfs_attr.c | 2 +- fs/xfs/xfs_attr.h | 1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index dd21784..4ed1e4c 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c @@ -763,6 +763,9 @@ xfs_setup_inode( break; } + if (!is_sgid(inode->i_mode) && !xfs_inode_hasattr(ip)) + inode->i_flags |= S_NOSEC; + xfs_iflags_clear(ip, XFS_INEW); barrier(); diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c index c863753..43140db 100644 --- a/fs/xfs/xfs_attr.c +++ b/fs/xfs/xfs_attr.c @@ -99,7 +99,7 @@ xfs_attr_name_to_xname( return 0; } -STATIC int +int xfs_inode_hasattr( struct xfs_inode *ip) { diff --git a/fs/xfs/xfs_attr.h b/fs/xfs/xfs_attr.h index e920d68..20f4038 100644 --- a/fs/xfs/xfs_attr.h +++ b/fs/xfs/xfs_attr.h @@ -142,5 +142,6 @@ typedef struct xfs_attr_list_context { int xfs_attr_inactive(struct xfs_inode *dp); int xfs_attr_rmtval_get(struct xfs_da_args *args); int xfs_attr_list_int(struct xfs_attr_list_context *); +int xfs_inode_hasattr(struct xfs_inode *ip); #endif /* __XFS_ATTR_H__ */ -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/