Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754913Ab1E1Rsf (ORCPT ); Sat, 28 May 2011 13:48:35 -0400 Received: from s15407518.onlinehome-server.info ([82.165.136.167]:51210 "EHLO s15407518.onlinehome-server.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550Ab1E1Rse (ORCPT ); Sat, 28 May 2011 13:48:34 -0400 From: Heiko =?iso-8859-15?q?St=FCbner?= To: Joe Perches Subject: Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc Date: Sat, 28 May 2011 19:48:12 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.37-2-686; KDE/4.4.5; i686; ; ) Cc: Jaya Kumar , Paul Mundt , Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , Jiri Kosina , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org References: <77538de911b8af99f68b7bcfbaaedce8e40db04f.1306603968.git.joe@perches.com> In-Reply-To: <77538de911b8af99f68b7bcfbaaedce8e40db04f.1306603968.git.joe@perches.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105281948.12941.heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 29 Am Samstag 28 Mai 2011, 19:36:32 schrieb Joe Perches: > diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c > index 3ec4923..86573e2 100644 > --- a/drivers/video/arcfb.c > +++ b/drivers/video/arcfb.c > @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct > platform_device *dev) > > /* We need a flat backing store for the Arc's > less-flat actual paged framebuffer */ > - if (!(videomemory = vmalloc(videomemorysize))) > + videomemory = vmalloc(videomemorysize); > + if (!videomemory) > return retval; shouldn't this be vzalloc too? > - memset(videomemory, 0, videomemorysize); > - > info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); > if (!info) > goto err; Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/