Date: Sun, 29 May 2011 09:38:40 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Arun Sharma <asharma@fb.com>, David Miller <davem@davemloft.net>,
        Maximilian Engelhardt <maxi@daemonizer.de>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        StuStaNet Vorstand <vorstand@stusta.mhn.de>,
        Yann Dupont <Yann.Dupont@univ-nantes.fr>,
        Denys Fedoryshchenko <denys@visp.net.lb>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Kernel crash after using new Intel NIC (igb)
Message-ID: <20110529073840.GB21254@elte.hu>
References: <4DDECA9B.8080206@fb.com>
 <1306447292.2543.32.camel@edumazet-laptop>
 <4DDEEBC5.80804@fb.com>
 <1306466831.2543.58.camel@edumazet-laptop>
 <4DDFE4D6.4010000@fb.com>
 <1306526219.2533.3.camel@edumazet-laptop>
 <20110527211419.GA6793@dev1756.snc6.facebook.com>
 <1306561285.2533.9.camel@edumazet-laptop>
 <20110528180434.GB12530@elte.hu>
 <1306654424.30021.7.camel@edumazet-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1306654424.30021.7.camel@edumazet-laptop>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1355
Lines: 41


* Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Le samedi 28 mai 2011 ? 20:04 +0200, Ingo Molnar a ?crit :
> > * Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > 
> > > > +static inline int atomic_add_unless(atomic_t *v, int a, int u)
> > > > +{
> > > > +	return __atomic_add_unless(v, a, u) != u;
> > > >  }
> > > >  
> > > >  #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
> > > 
> > > As I said, atomic_add_unless() has several implementations in 
> > > various arches. You must take care of all, not only x86.
> > 
> > It's a bit sad to see local hacks to generic facilities committed 
> > upstream like that.
> > 
> 
> Again, its a stable candidate patch, on a file that had many changes in
> recent kernels.
> 
> I felt this was the right thing to do, to ease stable teams work.

Yes and i do this all the time as well, to make life easier for the 
stable team.

What wasnt fine was to not follow up the backportable hack with the 
proper patch though. Or did you plan to do that yourself if Arun 
fails to complete the generic variant? (in which case my remark is 
moot)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/