Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752824Ab1E2KYW (ORCPT <rfc822;w@1wt.eu>);
	Sun, 29 May 2011 06:24:22 -0400
Received: from mail-pv0-f174.google.com ([74.125.83.174]:41546 "EHLO
	mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750731Ab1E2KYV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 29 May 2011 06:24:21 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:reply-to:organization:to:subject:date:user-agent:cc:references
         :in-reply-to:mime-version:content-type:content-transfer-encoding
         :message-id;
        b=jbC5db38LmHcl2xqFNqYKpbJ7BIJIcK0Cw8kr2MZnEWA8GSi8Xd6r/4ow25TR+a9bJ
         L+vwmEfNeha4MpQwgBOo1D8vOxwkw+cwlQO+xbMZoXBofSSQog66z68u5pTuEpDQTYxi
         c0e3wKpCVQ7I/puC3cja5kHJp+y2FfAXf2twQ=
From: Nai Xia <nai.xia@gmail.com>
Reply-To: nai.xia@gmail.com
Organization: Nanjing University
To: Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm: fix kernel BUG at mm/rmap.c:1017!
Date: Sun, 29 May 2011 18:23:46 +0800
User-Agent: KMail/1.13.5 (Linux/2.6.38.1; KDE/4.5.5; i686; ; )
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shaohua Li <shaohua.li@intel.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
References: <alpine.LSU.2.00.1105281314220.13319@sister.anvils>
In-Reply-To: <alpine.LSU.2.00.1105281314220.13319@sister.anvils>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201105291823.47082.nai.xia@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2350
Lines: 58

On Sunday 29 May 2011 04:17:04 Hugh Dickins wrote:
> I've hit the "address >= vma->vm_end" check in do_page_add_anon_rmap()
> just once.  The stack showed khugepaged allocation trying to compact
> pages: the call to page_add_anon_rmap() coming from remove_migration_pte().
> 
> That path holds anon_vma lock, but does not hold mmap_sem: it can
> therefore race with a split_vma(), and in commit 5f70b962ccc2 "mmap:
> avoid unnecessary anon_vma lock" we just took away the anon_vma lock
> protection when adjusting vma->vm_end.
> 
> I don't think that particular BUG_ON ever caught anything interesting,
> so better replace it by a comment, than reinstate the anon_vma locking.

Is there another racing between "vma->vm_pgoff = pgoff;" in 
vma_adjust() and linear_page_index() in __page_set_anon_rmap() ?


Nai Xia

> 
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>  mm/rmap.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux.orig/mm/rmap.c	2011-05-27 19:05:27.000000000 -0700
> +++ linux/mm/rmap.c	2011-05-27 20:07:44.601361236 -0700
> @@ -1014,7 +1014,7 @@ void do_page_add_anon_rmap(struct page *
>  		return;
>  
>  	VM_BUG_ON(!PageLocked(page));
> -	VM_BUG_ON(address < vma->vm_start || address >= vma->vm_end);
> +	/* address might be in next vma when migration races vma_adjust */
>  	if (first)
>  		__page_set_anon_rmap(page, vma, address, exclusive);
>  	else
> @@ -1709,7 +1709,7 @@ void hugepage_add_anon_rmap(struct page
>  
>  	BUG_ON(!PageLocked(page));
>  	BUG_ON(!anon_vma);
> -	BUG_ON(address < vma->vm_start || address >= vma->vm_end);
> +	/* address might be in next vma when migration races vma_adjust */
>  	first = atomic_inc_and_test(&page->_mapcount);
>  	if (first)
>  		__hugepage_set_anon_rmap(page, vma, address, 0);
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/