Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755793Ab1E2SP4 (ORCPT ); Sun, 29 May 2011 14:15:56 -0400 Received: from mail-px0-f179.google.com ([209.85.212.179]:54550 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755229Ab1E2SOR (ORCPT ); Sun, 29 May 2011 14:14:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=SzTV57iSUQctjpQ/m3+uYP1t0kab6X7ihLEOPw+rpaXTBTwEkpa98hzb3HuQBOXhiU NwUMYZn3TepXiKRk1Y2gqR21X295qXU2HRauPD59bGgyI5VC7AlrgxF2CoS2c6UCVXSd ykSyoCKGq9iPhVjJvJnvzdgyX9VMrDxrDo+qI= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Mel Gorman , Rik van Riel , Andrea Arcangeli , Johannes Weiner , Minchan Kim Subject: [PATCH v2 04/10] Add additional isolation mode Date: Mon, 30 May 2011 03:13:43 +0900 Message-Id: <5b0f0be7ee441ea27ffcad81d2637ac09407acf3.1306689214.git.minchan.kim@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 65 There are some places to isolate lru page and I believe users of isolate_lru_page will be growing. The purpose of them is each different so part of isolated pages should put back to LRU, again. The problem is when we put back the page into LRU, we lose LRU ordering and the page is inserted at head of LRU list. It makes unnecessary LRU churning so that vm can evict working set pages rather than idle pages. This patch adds new modes when we isolate page in LRU so we don't isolate pages if we can't handle it. It could reduce LRU churning. This patch doesn't change old behavior. It's just used by next patches. Cc: KOSAKI Motohiro Cc: Mel Gorman Cc: Rik van Riel Cc: Andrea Arcangeli Cc: Johannes Weiner Cc: KAMEZAWA Hiroyuki Signed-off-by: Minchan Kim --- include/linux/swap.h | 2 ++ mm/vmscan.c | 6 ++++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 37e4591..2718f8c 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -249,6 +249,8 @@ enum ISOLATE_PAGE_MODE { ISOLATE_INACTIVE = 1, /* Isolate inactive pages */ ISOLATE_ACTIVE = 2, /* Isolate active pages */ ISOLATE_BOTH = 4, /* Isolate both active and inactive pages */ + ISOLATE_CLEAN = 8, /* Isolate clean file */ + ISOLATE_UNMAPPED = 16, /* Isolate unmapped file */ }; /* linux/mm/vmscan.c */ diff --git a/mm/vmscan.c b/mm/vmscan.c index f03bb2e..9972356 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -992,6 +992,12 @@ int __isolate_lru_page(struct page *page, enum ISOLATE_PAGE_MODE mode, ret = -EBUSY; + if (mode & ISOLATE_CLEAN && (PageDirty(page) || PageWriteback(page))) + return ret; + + if (mode & ISOLATE_UNMAPPED && page_mapped(page)) + return ret; + if (likely(get_page_unless_zero(page))) { /* * Be careful not to clear PageLRU until after we're -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/