Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755020Ab1E3HfF (ORCPT ); Mon, 30 May 2011 03:35:05 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:34110 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731Ab1E3HfD (ORCPT ); Mon, 30 May 2011 03:35:03 -0400 Date: Mon, 30 May 2011 09:34:45 +0200 From: Ingo Molnar To: Len Brown Cc: Stephen Rothwell , Len Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, stable@kernel.org, Linus Torvalds , Andrew Morton Subject: Re: linux-next: build warningiIn Linus' tree Message-ID: <20110530073445.GA27557@elte.hu> References: <20110530114828.8ef6625b.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 44 * Len Brown wrote: > From: Len Brown > Date: Sun, 29 May 2011 23:38:15 -0400 > Subject: [PATCH] x86 idle: fix build warning for WARN_ONCE("idle=mwait") > > In 5d4c47e0195b989f284907358bd5c268a44b91c7 > "x86 idle: deprecate mwait_idle() and "idle=mwait" cmdline param"... > > I fat-fingered the editing when I updated the WARN_ONCE() string: > > arch/x86/kernel/process.c: In function 'idle_setup': > arch/x86/kernel/process.c:645:1: warning: unknown escape sequence: '\i' > > remove the '\n' while we are here, it works fine without it. > > Signed-off-by: Len Brown > --- > arch/x86/kernel/process.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Len, i'd *really* prefer it if patches changing arch/x86/ had a longer test time in linux-next than what you are gave it here. This kind of 'send them to lkml and merge them into your linux-next branch and send it to Linus on the same day' kind of ambush you have done with the 'x86 idle' patches might be convenient to you, but it is inconvenient to pretty much anyone else - and it is absolutely unacceptable to us x86 maintainers ... *Especially* as these patches were contentious when you last posted them as an RFC to lkml ... So please watch out for this in the future, ok? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/