Date: Mon, 30 May 2011 19:14:26 +0900
From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Borislav Petkov <bp@alien8.de>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        takuya.yoshikawa@gmail.com
Subject: Re: KVM build warnings
Message-Id: <20110530191426.336d23f4.yoshikawa.takuya@oss.ntt.co.jp>
In-Reply-To: <20110530094604.GC21833@liondog.tnic>
References: <20110530094604.GC21833@liondog.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1329
Lines: 31

On Mon, 30 May 2011 11:46:04 +0200
Borislav Petkov <bp@alien8.de> wrote:

> I get the following
> 
> In file included from arch/x86/kvm/mmu.c:2856:
> arch/x86/kvm/paging_tmpl.h: In function ‘paging32_walk_addr_generic’:
> arch/x86/kvm/paging_tmpl.h:124: warning: ‘ptep_user’ may be used uninitialized in this function
> In file included from arch/x86/kvm/mmu.c:2852:
> arch/x86/kvm/paging_tmpl.h: In function ‘paging64_walk_addr_generic’:
> arch/x86/kvm/paging_tmpl.h:124: warning: ‘ptep_user’ may be used uninitialized in this function
> 
> when building -rc1. It looks like it is caused by
> 6e2ca7d1802bf8ed9908435e34daa116662e7790 and sticking uninitialized_var() around
> the ptep_user declaration looks like the easiest solution. But the code should
> still be audited by someone who's familiar with it whether shutting up the
> compiler doesn't cause an actual bug.

Sorry, it is my commit.

I think the logic guarantees that ptep_user won't be used until it is
assigned some value.

It seems to be safe, IIUC.

  Takuya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/