Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756675Ab1E3LTo (ORCPT ); Mon, 30 May 2011 07:19:44 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:39254 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137Ab1E3LTn (ORCPT ); Mon, 30 May 2011 07:19:43 -0400 From: "Tomoya MORINAGA" To: "'Alan Cox'" , "'Greg KH'" Cc: , , , , , , References: <1306741324-4562-1-git-send-email-tomoya-linux@dsn.okisemi.com><20110530074722.GA7947@suse.de> <20110530105633.596ab8ab@bob.linux.org.uk> Subject: RE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH Date: Mon, 30 May 2011 20:19:40 +0900 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcwesbC7WluX1hHxSQGfNkCRQOFx1gABwXNA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 In-Reply-To: <20110530105633.596ab8ab@bob.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 23 Hi Greg > Because if the PCH driver is not available you want to bind > it to the 8250 driver, which also works with it but less efficiently. > > The giant if probably should be a pci match table however Which opinions should I select ? Though Alan's comment has a point, IMHO, in probe processing, the efficiently is not so important. Adding the "#ifdef", I think, readability of 8250_pci.c goes down. Thanks, ----------------------------------------- Tomoya MORINAGA OKI SEMICONDUCTOR CO., LTD. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/