Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757859Ab1E3TIo (ORCPT ); Mon, 30 May 2011 15:08:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23752 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757839Ab1E3TIn (ORCPT ); Mon, 30 May 2011 15:08:43 -0400 Date: Mon, 30 May 2011 21:07:13 +0200 From: Oleg Nesterov To: Mike Frysinger Cc: Andrew Morton , Roland McGrath , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] ptrace: unify show_regs() prototype Message-ID: <20110530190713.GA20616@redhat.com> References: <1302759489-10645-1-git-send-email-vapier@gentoo.org> <1306726753-16128-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306726753-16128-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 34 On 05/29, Mike Frysinger wrote: > > Signed-off-by: Mike Frysinger > --- > andrew: can you pick this up ? sent a few months ago w/no love. The patch looks obviously fine, I can put it into ptrace tree. Cough. Yes it is simple, but perhaps it still needs the changelog? Even a single line. One nit, > --- a/include/linux/ptrace.h > +++ b/include/linux/ptrace.h > @@ -100,6 +100,7 @@ > #include /* For struct task_struct. */ > > > +extern void show_regs(struct pt_regs *); Not sure ptrace.h is the right place. show_regs() has the callers which have nothing to do with ptrace. Hmm. You know what? show_regs() is already defined in sched.h, probably you can simply remove this chunk. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/