Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757857Ab1E3Wy1 (ORCPT ); Mon, 30 May 2011 18:54:27 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:47404 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688Ab1E3WyZ (ORCPT ); Mon, 30 May 2011 18:54:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=Pnx3BPNtDp1TqFNQbZ5/qxcvrwZAj1iM+d4upigsrmqj3U1Y8QTltS29E3SJHjXQz9 ZKUuw2RzInRTsDbWLXqIybPDhBGhQPqFD7gGwR6Yx+WOsm8hjmhVkG8d+/kwVpAKRUth YlJ72F5iYhxsHYn/aiWfe84vgixDDqHyPWhcM= MIME-Version: 1.0 In-Reply-To: <20110530190713.GA20616@redhat.com> References: <1302759489-10645-1-git-send-email-vapier@gentoo.org> <1306726753-16128-1-git-send-email-vapier@gentoo.org> <20110530190713.GA20616@redhat.com> From: Mike Frysinger Date: Mon, 30 May 2011 18:54:04 -0400 X-Google-Sender-Auth: FwQB3hxwWN6donis7VPDdP_LGwY Message-ID: Subject: Re: [PATCH] ptrace: unify show_regs() prototype To: Oleg Nesterov Cc: Andrew Morton , Roland McGrath , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 22 On Mon, May 30, 2011 at 15:07, Oleg Nesterov wrote: > On 05/29, Mike Frysinger wrote: >> --- a/include/linux/ptrace.h >> +++ b/include/linux/ptrace.h >> +extern void show_regs(struct pt_regs *); > > Not sure ptrace.h is the right place. show_regs() has the callers which > have nothing to do with ptrace. it needs pt_regs and everyone puts it in their own ptrace.h, so linux/ptrace.h was the logical common place for it > Hmm. You know what? show_regs() is already defined in sched.h, probably > you can simply remove this chunk. nice, i hadnt noticed. i'll send a new version. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/