Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537Ab1EaNOT (ORCPT ); Tue, 31 May 2011 09:14:19 -0400 Received: from mx2.fusionio.com ([66.114.96.31]:56399 "EHLO mx2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966Ab1EaNOS (ORCPT ); Tue, 31 May 2011 09:14:18 -0400 X-ASG-Debug-ID: 1306847656-01de280c1e0d670001-xx1T2L X-Barracuda-Envelope-From: JAxboe@fusionio.com Message-ID: <4DE4E9A6.8060006@fusionio.com> Date: Tue, 31 May 2011 15:14:14 +0200 From: Jens Axboe MIME-Version: 1.0 To: "Martin K. Petersen" CC: Mike Snitzer , "msb@chromium.org" , "linux-kernel@vger.kernel.org" , "dm-devel@redhat.com" Subject: Re: [PATCH 2/3] block: Move non-rotational flag to queue limits References: <4DDEA689.2090004@fusionio.com> <1306464169-4291-1-git-send-email-martin.petersen@oracle.com> <1306464169-4291-3-git-send-email-martin.petersen@oracle.com> <20110527130248.GA17219@redhat.com> X-ASG-Orig-Subj: Re: [PATCH 2/3] block: Move non-rotational flag to queue limits In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mail1.int.fusionio.com[10.101.1.21] X-Barracuda-Start-Time: 1306847656 X-Barracuda-URL: http://10.101.1.181:8000/cgi-mod/mark.cgi X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.65200 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 651 Lines: 18 On 2011-05-31 04:19, Martin K. Petersen wrote: > - queue_flag_set_unlocked(QUEUE_FLAG_NONROT, disk->queue); > + blk_queue_non_rotational(queue); I don't like this part of the change. Before it was immediately apparently that we were setting this flag, know you have no idea what it does. Please make that blk_queue_set_non_rotational(). Otherwise looks fine. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/