Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757113Ab1EaQKc (ORCPT ); Tue, 31 May 2011 12:10:32 -0400 Received: from mga09.intel.com ([134.134.136.24]:41876 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756776Ab1EaQKb (ORCPT ); Tue, 31 May 2011 12:10:31 -0400 X-ExtLoop1: 1 Subject: Re: [PATCH 14/14] tmpfs: no need to use i_lock From: Tim Chen To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 31 May 2011 09:08:10 -0700 Message-ID: <1306858090.2577.147.camel@schen9-DESK> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 944 Lines: 26 On Mon, 2011-05-30 at 17:55 -0700, Hugh Dickins wrote: > 2.6.36's 7e496299d4d2 to make tmpfs scalable with percpu_counter used > inode->i_lock in place of sbinfo->stat_lock around i_blocks updates; > but that was adverse to scalability, and unnecessary, since info->lock > is already held there in the fast paths. > > Remove those uses of i_lock, and add info->lock in the three error > paths where it's then needed across shmem_free_blocks(). It's not > actually needed across shmem_unacct_blocks(), but they're so often > paired that it looks wrong to split them apart. > > Signed-off-by: Hugh Dickins > Cc: Tim Chen > --- Acked. Tim Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/