DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=a27R9BFRiy//+qBTRUq5+FP0L6AWIPCz59L3M5TZjIadR16vj0dJqSuM2vnFETtmRG6b+zjmDmA63GrP4XF++GBDmNre2qOHbMABTi2La5hPKwQvla9+u3EsGCosFtgI;
Date: Tue, 31 May 2011 09:57:37 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jason Stubbs <jasonbstubbs@gmail.com>
Cc: Keith Packard <keithp@keithp.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: fix regression after clock gating init split
Message-ID: <20110531095737.0adbbfee@jbarnes-desktop>
In-Reply-To: <201105281426.28488.jasonbstubbs@gmail.com>
References: <201105272344.20084.jasonbstubbs@gmail.com>
	<yunaae8j5dg.fsf@aiko.keithp.com>
	<201105281426.28488.jasonbstubbs@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1789
Lines: 47

On Sat, 28 May 2011 14:26:28 +1000
Jason Stubbs <jasonbstubbs@gmail.com> wrote:

> On Sat, 28 May 2011 05:44:11 Keith Packard wrote:
> > On Fri, 27 May 2011 23:44:19 +1000, Jason Stubbs <jasonbstubbs@gmail.com> 
> wrote:
> > > From: Jason Stubbs <jasonbstubbs@gmail.com>
> > > 
> > > However, there are some code paths, notably IS_PINEVIEW(dev), where 
> > > init_clock_gating is not set and not needed.
> > 
> > Looks like Pineview should be using the gen3_init_clock_gating function.
> 
> Yep, you are right. Adding printk()s to the original implementation confirmed 
> that - at least on my hardware. I should have known to check that...
> 
> There are two other code paths where an init_clock_gating function isn't 
> specified though. The specific code paths are:
> 
> HAS_PCH_SPLIT() && !IS_GEN5() && !IS_GEN6() && !IS_IVYBRIDGE()
> 
> Looking at the original intel_enable_clock_gating() function, there would
> have been some intialization done for this case.
> 
> IS_GEN4() && !IS_CRESTLINE() && !IS_BROADWATER()
> 
> It looks like this would have gone into the final "no gating match" if/else 
> branch.
> 
> If both of the above don't happen in the real world, then I guess it's fine as 
> is. If either are possible, then they need to be fixed too.
> 
> I'll just (re)send a patch for the IS_PINEVIEW() case and leave the above to
> somebody who knows better than I...

Yeah, the above combos aren't valid, so I don't think we need to handle
them.

Thanks for the Pineview fix!

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/