Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519Ab1EaVB0 (ORCPT ); Tue, 31 May 2011 17:01:26 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46376 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242Ab1EaVBZ (ORCPT ); Tue, 31 May 2011 17:01:25 -0400 Date: Tue, 31 May 2011 22:00:27 +0100 From: Russell King - ARM Linux To: David Rientjes , Andrew Morton Cc: Dmitry Eremin-Solenikov , Nicolas Pitre , linux-arm-kernel , linux-kernel , Eric Miao , Samuel Ortiz Subject: Re: IrDA driver fails on PXA255 Message-ID: <20110531210027.GA3660@n2100.arm.linux.org.uk> References: <20110528205701.GA1788@doriath.ww600.siemens.net> <20110529215656.GA5576@n2100.arm.linux.org.uk> <20110531072650.GC21382@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 33 On Tue, May 31, 2011 at 01:03:03PM -0700, David Rientjes wrote: > The problem certainly isn't being ignored in this thread, or in the patch > that I sent to fix Dmitry's issue by default, so that doesn't seem to be > the case. What would be ignored, though, is if it just emitted a > WARN_ON() without failing the allocation so everything works perfectly. Sorry, you did not send a patch to fix it. You sent a *bodge* to enable the DMA zone. As long as you insist that's a valid fix, you're going to carry zero credibility with me. The fact is that this driver should not be using GFP_DMA to allocate things which aren't even DMA buffers, and its use of GFP_DMA should be removed. But rather than look at that and work it out, and then produce a patch to sort that out, the only thing you can do is come up with bodge to enable the DMA zone, and continue to insist that's the right solution. I repeat, enabling the DMA zone for this driver is a pure and utter bodge, and the change to make these allocations fail _will_ and _has_ caused regressions. Your whinge that we should re-enable the DMA zone which has been disabled for quite a long time now to work around this new restriction is extremely idiotic. Do the right thing. Make allocations to GFP_DMA zones _warn_ first for a cycle so that affected drivers can be fixed. Then for the next cycle, make it a hard failure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/