Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709Ab1EaVS1 (ORCPT ); Tue, 31 May 2011 17:18:27 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:36604 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932497Ab1EaVS0 (ORCPT ); Tue, 31 May 2011 17:18:26 -0400 MIME-Version: 1.0 In-Reply-To: <4DE51EB7.7010606@stericsson.com> References: <1306830661-9546-1-git-send-email-mattias.wallin@stericsson.com> <4DE51EB7.7010606@stericsson.com> Date: Tue, 31 May 2011 23:18:25 +0200 Message-ID: Subject: Re: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support From: Linus Walleij To: Mattias Wallin Cc: Thomas Gleixner , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 32 On Tue, May 31, 2011 at 7:00 PM, Mattias Wallin wrote: > On 05/31/2011 12:38 PM, Thomas Gleixner wrote: >>> +++ b/include/linux/clksrc-db8500-prcmu.h >> Huch, why needs this to be a separate head in include/linux ? > > I will move the header file to mach-ux500/include/mach/. Ok? > > (I have long time ago been thought to avoid include mach headers from the > drivers. But if I understand it correct it is not true any more and in this > case it certainly makes no sense since I break that rule myself.) Keeping it under include/linux is probably wise since we want drivers OUT of the ARM tree, but I don't know if there is much consensus on that? I was more understanding the question as why it was needed at all. Does it work to register the clocksource with say a core_initcall() and avoid the header altogether? Else a header is needed since we need to call out from the platform timer init function to this clocksource to register it. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/