Date: Tue, 31 May 2011 15:23:46 -0700 (PDT)
Message-Id: <20110531.152346.160925902.davem@davemloft.net>
To: cmdkhh@gmail.com
Cc: bp@alien8.de, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ide-cd: Fix signedness warning
From: David Miller <davem@davemloft.net>
In-Reply-To: <1306739612-29239-1-git-send-email-cmdkhh@gmail.com>
References: <1306739612-29239-1-git-send-email-cmdkhh@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 23

From: Connor Hansen <cmdkhh@gmail.com>
Date: Mon, 30 May 2011 00:13:32 -0700

> One of the legit warnings 'make W=3 drivers/ide/ide-cd.o? generates is
> 
> drivers/ide/ide-cd.c: In function .ide_cdrom_prep_fs.:
> drivers/ide/ide-cd.c:1314: warning: conversion to .unsigned int. from .int. may change the sign of the result
> 
> because queue_logical_block_size() returns unsigned short but hard_sect
> is defined as int. Fix that no matter how low the potential for this
> becoming a bug is.
> 
> Signed-off-by: Connor Hansen <cmdkhh@gmail.com>

An 'int' can always hold as large a value as an "unsigned short" can ever
hold, so there is no real problem here.

I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/