Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933009Ab1FAAZk (ORCPT ); Tue, 31 May 2011 20:25:40 -0400 Received: from tundra.namei.org ([65.99.196.166]:39146 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932986Ab1FAAZj (ORCPT ); Tue, 31 May 2011 20:25:39 -0400 Date: Wed, 1 Jun 2011 10:25:37 +1000 (EST) From: James Morris To: Kees Cook cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] AppArmor: fix oops in apparmor_setprocattr In-Reply-To: <20110531183141.GH19633@outflux.net> Message-ID: References: <20110531183141.GH19633@outflux.net> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 24 On Tue, 31 May 2011, Kees Cook wrote: > When invalid parameters are passed to apparmor_setprocattr a NULL deref > oops occurs when it tries to record an audit message. This is because > it is passing NULL for the profile parameter for aa_audit. But aa_audit > now requires that the profile passed is not NULL. > > Fix this by passing the current profile on the task that is trying to > setprocattr. Is this trigger able by unprivileged users? >From which upstream commit is this an issue? - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/