Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933120Ab1FABMd (ORCPT ); Tue, 31 May 2011 21:12:33 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:18287 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933005Ab1FABMa convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2011 21:12:30 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 31 May 2011 18:12:21 -0700 From: Andrew Chew To: "'Guennadi Liakhovetski'" CC: "mchehab@redhat.com" , "olof@lixom.net" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 31 May 2011 18:12:20 -0700 Subject: RE: [PATCH 3/5 v2] [media] ov9740: Fixed some settings Thread-Topic: [PATCH 3/5 v2] [media] ov9740: Fixed some settings Thread-Index: Acwd6i+UWJJ8N0goQgaJjVEz+0rUvQCDp6jA Message-ID: <643E69AA4436674C8F39DCC2C05F76382A75BF37C2@HQMAIL03.nvidia.com> References: <1306368272-28279-1-git-send-email-achew@nvidia.com> <1306368272-28279-3-git-send-email-achew@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 18 > > + { OV9740_MIPI_CTRL00, 0x64 }, /* 0x44 for > continuous clock */ > > I think, the choice between continuous and discontinuous CSI-2 clock > should become configurable. You can only use discontinuous clock with > hosts, that support it, right? Whereas all hosts must support > continuous > clock. So, I'm not sure we should unconditionally switch to > discontinuous > clock here... Maybe it's better to keep it continuous until > we make it > configurable? Yes, that's right. The camera host needs to support discontinuous clocks. I'll change it back to continuous clock by default, and change the comment to "0x64 for discontinuous clock", so we remember for when this becomes configurable.-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/