Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755899Ab1FAHyt (ORCPT ); Wed, 1 Jun 2011 03:54:49 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:57580 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755623Ab1FAHys (ORCPT ); Wed, 1 Jun 2011 03:54:48 -0400 Date: Wed, 1 Jun 2011 08:54:20 +0100 From: Russell King - ARM Linux To: David Rientjes Cc: Andrew Morton , Dmitry Eremin-Solenikov , Nicolas Pitre , linux-arm-kernel , linux-kernel , Eric Miao , Samuel Ortiz Subject: Re: IrDA driver fails on PXA255 Message-ID: <20110601075420.GB3660@n2100.arm.linux.org.uk> References: <20110528205701.GA1788@doriath.ww600.siemens.net> <20110529215656.GA5576@n2100.arm.linux.org.uk> <20110531072650.GC21382@n2100.arm.linux.org.uk> <20110531210027.GA3660@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 15 On Tue, May 31, 2011 at 03:11:40PM -0700, David Rientjes wrote: > The restriction isn't new: GFP_DMA only makes sense with CONFIG_ZONE_DMA. > The fact that the page allocator completely ignored GFP_DMA in the past > for CONFIG_ZONE_DMA=n doesn't change that. That's obviously error prone > since it will return memory from anywhere simply because of the fact that > it is an invalid configuration. Your approach to this is wrong. Make it warn for one release. Give people a chance to fix things before they become a regression. Then make it a hard failure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/