Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759835Ab1FAULz (ORCPT ); Wed, 1 Jun 2011 16:11:55 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:38402 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752933Ab1FAULy (ORCPT ); Wed, 1 Jun 2011 16:11:54 -0400 Date: Wed, 01 Jun 2011 13:11:36 -0700 (PDT) Message-Id: <20110601.131136.391831410750786951.davem@davemloft.net> To: julia@diku.dk Cc: joe@perches.com, wg@grandegger.com, kernel-janitors@vger.kernel.org, socketcan-core@lists.berlios.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put From: David Miller In-Reply-To: References: <1306948213-20767-4-git-send-email-julia@diku.dk> <1306949175.32125.20.camel@Joe-Laptop> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 01 Jun 2011 13:11:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 34 From: Julia Lawall Date: Wed, 1 Jun 2011 22:08:46 +0200 (CEST) > On Wed, 1 Jun 2011, Joe Perches wrote: > >> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote: >> > The failed_get label is used after the call to clk_get has succeeded, so it >> > should be moved up above the call to clk_put. >> [] >> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c >> [] >> > @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev) >> > failed_map: >> > release_mem_region(mem->start, mem_size); >> > failed_req: >> > - clk_put(clk); >> > failed_get: >> > + clk_put(clk); >> > failed_clock: >> > return err; >> >> If this is correct, it might be better to rename all the >> uses of failed_req to failed_get and delete label failed_req. > > As I replied to Walter Harms, I believe it is correct, because I don't see > anything in the called functions that needs to be freed. I can redo the > patch to eliminate the label. Please do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/