Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395Ab1FAUNM (ORCPT ); Wed, 1 Jun 2011 16:13:12 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:41941 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753845Ab1FAUNK (ORCPT ); Wed, 1 Jun 2011 16:13:10 -0400 Date: Wed, 1 Jun 2011 22:13:05 +0200 (CEST) From: Julia Lawall To: David Miller Cc: joe@perches.com, wg@grandegger.com, kernel-janitors@vger.kernel.org, socketcan-core@lists.berlios.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put In-Reply-To: <20110601.131136.391831410750786951.davem@davemloft.net> Message-ID: References: <1306948213-20767-4-git-send-email-julia@diku.dk> <1306949175.32125.20.camel@Joe-Laptop> <20110601.131136.391831410750786951.davem@davemloft.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 40 On Wed, 1 Jun 2011, David Miller wrote: > From: Julia Lawall > Date: Wed, 1 Jun 2011 22:08:46 +0200 (CEST) > > > On Wed, 1 Jun 2011, Joe Perches wrote: > > > >> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote: > >> > The failed_get label is used after the call to clk_get has succeeded, so it > >> > should be moved up above the call to clk_put. > >> [] > >> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > >> [] > >> > @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev) > >> > failed_map: > >> > release_mem_region(mem->start, mem_size); > >> > failed_req: > >> > - clk_put(clk); > >> > failed_get: > >> > + clk_put(clk); > >> > failed_clock: > >> > return err; > >> > >> If this is correct, it might be better to rename all the > >> uses of failed_req to failed_get and delete label failed_req. > > > > As I replied to Walter Harms, I believe it is correct, because I don't see > > anything in the called functions that needs to be freed. I can redo the > > patch to eliminate the label. > > Please do. OK, I will do it tomorrow. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/