Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758994Ab1FBBZa (ORCPT ); Wed, 1 Jun 2011 21:25:30 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:63934 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525Ab1FBBZ3 convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2011 21:25:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=oPUFolPOHeYVxiepWRymTkykhfsTtssQmbpNndXfuiYQ3v73rJel7Z6uZu85azRQOv NfSgLUPs1TCOxeTbVwQcMEOSCRZcWKpYlbt2ONMbulIj6F7IqtGREJWFZOES8N+skr6p 0bsgS/lHDi/StzhG5D53ZQ5YloObjBUgkpqGE= MIME-Version: 1.0 In-Reply-To: <46950A08-9300-4649-A38D-88829035DFC2@dilger.ca> References: <1306939009-11283-1-git-send-email-akinobu.mita@gmail.com> <46950A08-9300-4649-A38D-88829035DFC2@dilger.ca> Date: Thu, 2 Jun 2011 10:25:28 +0900 Message-ID: Subject: Re: [PATCH v2 1/2] ext4: arrange ext4_*_bit() macros From: Akinobu Mita To: Andreas Dilger Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , linux-ext4@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1754 Lines: 37 2011/6/2 Andreas Dilger : > On 2011-06-01, at 8:36 AM, Akinobu Mita wrote: >> - remove unused ext4_{set,clear}_bit_atomic and ext4_find_first_zero_bit >> - rename ext4_{set,clear}_bit to ext4_test_and_{set,clear}_bit >> - reintroduce ext4_{set,clear}_bit for __{set,clear}_bit_le >> >> This changes ext4_{set,clear}_bit safely, because if someone uses >> these macros without noticing the change, new ext4_{set,clear}_bit >> don't have return value and causes compiler errors where the return >> value is used. > > I don't think it makes sense to change all of the ext4_set_bit() calls that > don't check the return code to use ext4_test_and_set_bit(), just to return > them back to ext4_set_bit() in the next patch. > > If you want to do this in separate steps, and maintain git bisect working, > then it would be more clear to have two patches: > > Patch #1: Add new ext4_test_and_set_bit() macro > #define ext4_test_and_set_bit ? ? ? ? ? __test_and_set_bit_le > {change ext4_set_bit() calls that check return to ?ext4_test_and_set_bit()} > > Patch #2: Change ext4_set_bit() to not return old bit > #define ext4_set_bit ? ? ? ? ? ? ? ? ? ?__set_bit_le > {nothing else changes} > > Alternately, you could just leave the calls that do not check the return > value as ext4_set_bit() and have only a single patch. OK, I will do in a single patch. The change will be much smaller than this version because there are only two calls where ext4_{set,clear}_bit() checks the return value. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/