Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932544Ab1FBFwP (ORCPT ); Thu, 2 Jun 2011 01:52:15 -0400 Received: from mail-px0-f179.google.com ([209.85.212.179]:60574 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932362Ab1FBFwK (ORCPT ); Thu, 2 Jun 2011 01:52:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=FrH+PcihIZ3teVRTp5NGu3tihqs/E3/PbRlRxMB+4nAlyRUGQ7ghhQLH4N3W/GV7n/ OMG4cXis6W8PFsvPIN6KAnrYcRGVZ9dxlGwfZP2mki0ihUXk82sQMnj3BgB3cquQiBHM GDiaQzuCMDe1CxrXn1UvOF7a7TxZJDa7MHr4E= From: Connor Hansen To: davem@davemloft.net Cc: bp@alien8.de, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Connor Hansen Subject: [PATCH] ide-cd: signedness warning fix again Date: Wed, 1 Jun 2011 22:52:05 -0700 Message-Id: <1306993925-26044-1-git-send-email-cmdkhh@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 40 One of the legit warnings 'make W=3 drivers/ide/ide-cd.c' generates is: drivers/ide/ide-cd.c: In function ide_cd_do_request drivers/ide/ide-cd.c:828:2: warning: conversion to int from \ unsigned int may change the sign of the result drivers/ide/ide-cd.c:833:2: warning: conversion to int from \ unsigned int may change the sign of the result nsectors is declared int, should be unsigned int. blk_rq-sectors() returns unsigned int, and ide_complete_rq expects unsigned int as well. Fixes both warnings. Signed-off-by: Connor Hansen --- drivers/ide/ide-cd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 5d17ab4..0a61f63 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -778,7 +778,8 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq, sector_t block) { struct ide_cmd cmd; - int uptodate = 0, nsectors; + int uptodate = 0; + unsigned int nsectors; ide_debug_log(IDE_DBG_RQ, "cmd: 0x%x, block: %llu", rq->cmd[0], (unsigned long long)block); -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/