Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759787Ab1FBJFV (ORCPT ); Thu, 2 Jun 2011 05:05:21 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:54279 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407Ab1FBJFT (ORCPT ); Thu, 2 Jun 2011 05:05:19 -0400 Date: Thu, 2 Jun 2011 11:05:09 +0200 From: Ingo Molnar To: Joe Perches Cc: Andrew Morton , linux-kernel@vger.kernel.org, Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo Subject: Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern Message-ID: <20110602090509.GB7800@elte.hu> References: <8d1e596980a6b6fec79432bb5a5953985cf85c2f.1306950701.git.joe@perches.com> <20110602074057.GE2150@elte.hu> <1307003167.32125.59.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1307003167.32125.59.camel@Joe-Laptop> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 41 * Joe Perches wrote: > On Thu, 2011-06-02 at 09:40 +0200, Ingo Molnar wrote: > > * Joe Perches wrote: > > > No arch/*/lib/perf_event* files exist so remove the pattern. > > The arch/*/lib/ hierarchy is a common place to put stuff into, it > > does not hurt at all to have it mentioned. > > Every once in awhile I run a script on MAINTAINERS > and fix up defects found by the script. > > Dead code is dead code. > This was unused as of commit e360adbe2924. NAK, i've outlined my reasons: - It's an obvious pattern to put librarized functionality in there and should an architecture grow a file there in the future it will be included automatically. - What we are interested in are false positives (files included that should not be matched) and false negatives (files belonging to a subsystm not included) - this pattern is none of those. > > stop mucking with these patterns and start dealing with some of > > the more important problems we have? > > My time, my choice on what to do with it. Yes, but this time you are also wasting my time with such a stupid patch, so it's not just your time wasted anymore. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/