Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933387Ab1FBKRf (ORCPT ); Thu, 2 Jun 2011 06:17:35 -0400 Received: from adelie.canonical.com ([91.189.90.139]:39195 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933096Ab1FBKRe (ORCPT ); Thu, 2 Jun 2011 06:17:34 -0400 Message-ID: <4DE76338.30706@canonical.com> Date: Thu, 02 Jun 2011 18:17:28 +0800 From: Ike Panhc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Corentin Chary CC: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Garrett Subject: Re: [PATCH 3/3] ideapad: Show negative when no camera References: <1307006553-12667-1-git-send-email-ike.pan@canonical.com> <1307006687-12736-1-git-send-email-ike.pan@canonical.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 500 Lines: 12 On 06/02/2011 05:43 PM, Corentin Chary wrote: > I think it would be better to not add the file when the camera is not > available. Another option is to return -ENODEV. But printing -1 > doesn't seems right. > Agree, making the node invisible is better. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/