Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751493Ab1FBO2A (ORCPT ); Thu, 2 Jun 2011 10:28:00 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:40838 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710Ab1FBO17 (ORCPT ); Thu, 2 Jun 2011 10:27:59 -0400 Date: Thu, 2 Jun 2011 16:27:38 +0200 From: Johannes Weiner To: Hiroyuki Kamezawa Cc: KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Ying Han , Michal Hocko , Andrew Morton , Rik van Riel , Minchan Kim , KOSAKI Motohiro , Mel Gorman , Greg Thelen , Michel Lespinasse , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 7/8] vmscan: memcg-aware unevictable page rescue scanner Message-ID: <20110602142738.GC28684@cmpxchg.org> References: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> <1306909519-7286-8-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 23 On Thu, Jun 02, 2011 at 10:27:15PM +0900, Hiroyuki Kamezawa wrote: > 2011/6/1 Johannes Weiner : > > Once the per-memcg lru lists are exclusive, the unevictable page > > rescue scanner can no longer work on the global zone lru lists. > > > > This converts it to go through all memcgs and scan their respective > > unevictable lists instead. > > > > Signed-off-by: Johannes Weiner > > Hm, isn't it better to have only one GLOBAL LRU for unevictable pages ? > memcg only needs counter for unevictable pages and LRU is not necessary > to be per memcg because we don't reclaim it... That's true, and I will look into it. But keep in mind that it needs special-casing that one list type from all the others, so maybe it's just easier to keep it like this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/