Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555Ab1FBOxH (ORCPT ); Thu, 2 Jun 2011 10:53:07 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:41784 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752198Ab1FBOxF (ORCPT ); Thu, 2 Jun 2011 10:53:05 -0400 Date: Thu, 2 Jun 2011 10:53:04 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Julia Lawall cc: David Brownell , , Greg Kroah-Hartman , , Subject: Re: [PATCH] drivers/usb/gadget/inode.c: add missing kfree In-Reply-To: <1307003186-23244-1-git-send-email-julia@diku.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 32 On Thu, 2 Jun 2011, Julia Lawall wrote: > From: Julia Lawall > > The label fail frees dev->buf, but kbuf hasn't yet been stored there at > this point. ... > Signed-off-by: Julia Lawall > > --- > I wonder if it is really correct to free dev->buf at fail in this case. > Because it is freeing the previously allocated value of dev->buf, not the > current one as done in subsequent cases. I don't think it matters. This check is probably there only for safety; it should not be possible for dev->buf to be non-NULL at this point. You ought to be able to remove the entire if (dev->buf) goto fail; statement with no ill effects. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/