Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754723Ab1FCA6m (ORCPT ); Thu, 2 Jun 2011 20:58:42 -0400 Received: from lennier.cc.vt.edu ([198.82.162.213]:45300 "EHLO lennier.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753866Ab1FCA6i (ORCPT ); Thu, 2 Jun 2011 20:58:38 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3-dev To: Dan Williams Cc: Alexey ORISHKO , Stefan Metzmacher , Oliver Neukum , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN In-Reply-To: Your message of "Thu, 02 Jun 2011 17:35:31 CDT." <1307054132.21633.25.camel@dcbw.foobar.com> From: Valdis.Kletnieks@vt.edu References: <1306922913-17803-1-git-send-email-metze@samba.org> <1306922913-17803-2-git-send-email-metze@samba.org> <2AC7D4AD8BA1C640B4C60C61C8E520153E3C07E583@EXDCVYMBSTM006.EQ1STM.local> <1307053743.21633.22.camel@dcbw.foobar.com> <1307054132.21633.25.camel@dcbw.foobar.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1307062683_2826P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Thu, 02 Jun 2011 20:58:03 -0400 Message-ID: <5203.1307062683@turing-police.cc.vt.edu> X-Mirapoint-Received-SPF: 198.82.161.152 auth3.smtp.vt.edu Valdis.Kletnieks@vt.edu 2 pass X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Status: score=10/50, host=dagger.cc.vt.edu X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A02020A.4DE8319F.00A1,ss=1,fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-Junkmail-IWF: false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2077 Lines: 51 --==_Exmh_1307062683_2826P Content-Type: text/plain; charset=us-ascii On Thu, 02 Jun 2011 17:35:31 CDT, Dan Williams said: > On Thu, 2011-06-02 at 17:29 -0500, Dan Williams wrote: > > On Wed, 2011-06-01 at 12:20 +0200, Alexey ORISHKO wrote: > > > > -----Original Message----- > > > > From: netdev-owner@vger.kernel.org [mailto:netdev- > > > > owner@vger.kernel.org] On Behalf Of Stefan Metzmacher > > > > Sent: Wednesday, June 01, 2011 12:09 PM > > > > > > > > > > - .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET, > > > > + .flags = FLAG_WWAN | FLAG_NO_SETINT | FLAG_MULTI_PACKET, > > > > > > This patch will introduce incompatibility with already existing > > > applications, which track usbX devices. As a result, end user > > > application will stop working. I'm interpreting this as "devices which currently often get named usbX by udev, and currently have FLAG_POINTTOPOINT set". People are getting hung up on the usbX part, not what the *real* problem is. > A follow-on to this is that if you really care about specific devices, > your application can use udev rules to "tag" specific interfaces based > on USB VID/PID/GUID or other device attributes, and check for those tags > in your program. Use udev (good) or netlink (good) or SIOCGIFCONF (bad) > to enumerate the various network interfaces on the system and pick the I think Alexey's point was that the patch will hose up programs that currently do the netlink or SIOCGIFCONF thing and look for FLAG_POINTTOPOINT. --==_Exmh_1307062683_2826P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFN6DGbcC3lWbTT17ARAkF8AJ0V4sNPAGtfzochn9YOiESfVr2pyQCg7T3G ad/XKV6nkoGyoOp07qe5xFI= =Qr1U -----END PGP SIGNATURE----- --==_Exmh_1307062683_2826P-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/