Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755647Ab1FCCGW (ORCPT ); Thu, 2 Jun 2011 22:06:22 -0400 Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:33981 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab1FCCGU (ORCPT ); Thu, 2 Jun 2011 22:06:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuIDAOY+6E15LCoegWdsb2JhbABTpjkVAQEWJiXJcQ6GEwSYOId4 Date: Fri, 3 Jun 2011 12:06:15 +1000 From: Dave Chinner To: Kyungmin Park Cc: Chris Mason , Lukas Czerner , Christoph Hellwig , Mark Lord , James Bottomley , Matthew Wilcox , Josef Bacik , tytso , linux-ext4 , linux-kernel , linux-fsdevel , sandeen Subject: Re: [PATCH 1/2] fs: Do not dispatch FITRIM through separate super_operation Message-ID: <20110603020615.GZ561@dastard> References: <20101118142918.GA18510@infradead.org> <1290100750.3041.72.camel@mulgrave.site> <4CE59C9E.6050902@teksavvy.com> <1290177488-sup-6540@think> <4CE68F80.7000607@teksavvy.com> <20101119145748.GB27919@infradead.org> <4CE695FF.20601@teksavvy.com> <20101207092749.GA26100@infradead.org> <1291740643-sup-2494@think> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 43 On Thu, Jun 02, 2011 at 01:52:12PM +0900, Kyungmin Park wrote: > On Wed, Dec 8, 2010 at 1:52 AM, Chris Mason wrote: > > Excerpts from Christoph Hellwig's message of 2010-12-07 04:27:49 -0500: > >> On Fri, Nov 19, 2010 at 10:21:35AM -0500, Mark Lord wrote: > >> > >I really hate to rely on this third party hearsay (from all sides), and > >> > >have implement TRIM support in qemu now. ?I'll soon install win7 and > >> > >will check out the TRIM patters myself. > >> > > >> > Excellent! > >> > >> I did a Windows 7 installation under qemu today, and the result is: > > > > Great, thanks for testing this. > > > >> > >> ?- it TRIMs the whole device early during the installation > >> ?- after that I see a constant stream of small trims during the > >> ? ?installation. ?It's using lots of non-contiguous ranges in a single > >> ? ?TRIM command, with sizes down to 8 sectors (4k) for a single range. > >> ?- after installation there's is some background-trimming going on > >> ? ?even when doing no user interaction with the VM at all. > > Hi Lukas, > > Now FITRIM is based on user interaction. So how about to implement the > AUTO batched discard at kernel level? > Idea is same as windows, make a single thread and iterate the > superblocks and call the trim. Surely this the responsibility of a userspace daemon and a config file to decide and implement the background trim policy? Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/