Date: Fri, 3 Jun 2011 08:52:01 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, patches@linaro.org,
        grant.likely@secretlab.ca, kernel@pengutronix.de, olof@lixom.net,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio
Message-ID: <20110603075201.GE10532@n2100.arm.linux.org.uk>
References: <1306985632-18820-1-git-send-email-shawn.guo@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1306985632-18820-1-git-send-email-shawn.guo@linaro.org>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 22

On Thu, Jun 02, 2011 at 11:33:48AM +0800, Shawn Guo wrote:
>  arch/arm/plat-mxc/gpio.c                        |  361 -------------------
>  drivers/gpio/gpio-mxc.c                         |  433 +++++++++++++++++++++++

I'm wondering why just moving this driver into drivers/gpio has
resulted in it growing by 72 lines - and it's not clear from the
diffs why that is because of the way they're broken up.

Would it not be better to have the first patch to merely move
arch/arm/plat-mxc/gpio.c to drivers/gpio/gpio-mxc.c, making whatever
config changes are necessary.  Then subsequent patches should change
drivers/gpio/gpio-mxc.c as required - which means we can see what
changes are being made.

As the series currently stands, from the review point of view it's
effectively adding an entirely new driver, converting everything over
to it, and then deleting the old.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/