From: Arnd Bergmann <arnd@arndb.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH] asm-generic: add another generic ext2 atomic bitops
Date: Fri, 3 Jun 2011 18:00:22 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        linux-arch@vger.kernel.org
References: <1306938736-11119-1-git-send-email-akinobu.mita@gmail.com>
In-Reply-To: <1306938736-11119-1-git-send-email-akinobu.mita@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201106031800.22298.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 773
Lines: 20

On Wednesday 01 June 2011, Akinobu Mita wrote:
> The majority of architectures implement ext2 atomic bitops as
> test_and_{set,clear}_bit() without spinlock.
> 
> This adds this type of generic implementation in ext2-atomic.h and
> use it wherever possible.

The idea sounds really good, but I'm trying to keep the number of
ARCH_* macros low. How about instead providing a new
asm-generic/bitops/ext2-atomic-setbit.h or similar?

Each architecture can then include either the spinlock or the
atomic bitop based version.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/