Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952Ab1FCRm0 (ORCPT ); Fri, 3 Jun 2011 13:42:26 -0400 Received: from mail-px0-f179.google.com ([209.85.212.179]:41607 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965Ab1FCRmY convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2011 13:42:24 -0400 MIME-Version: 1.0 In-Reply-To: <20110603171837.GA9918@opensource.wolfsonmicro.com> References: <20110523155343.2e68c265.randy.dunlap@oracle.com> <20110524000837.GA30515@opensource.wolfsonmicro.com> <4DDB082F.3010107@oracle.com> <20110524014959.GA27710@opensource.wolfsonmicro.com> <4DDB3AFF.9030006@oracle.com> <20110524075248.GB19734@sirena.org.uk> <20110527074552.GA907@ponder.secretlab.ca> <4DDFE391.2030507@oracle.com> <20110527201201.GA6645@ponder.secretlab.ca> <20110603171837.GA9918@opensource.wolfsonmicro.com> From: Grant Likely Date: Fri, 3 Jun 2011 11:42:04 -0600 X-Google-Sender-Auth: 4kGGIWKVtvUhwIp-7pwlqsF6FnE Message-ID: Subject: Re: [PATCH] gpio: add GPIOF_ values regardless on kconfig settings To: Mark Brown Cc: Randy Dunlap , Stephen Rothwell , alsa-devel@alsa-project.org, Dmitry Artamonow , x86@kernel.org, LKML , linux-next@vger.kernel.org, Harald Welte Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 30 On Fri, Jun 3, 2011 at 11:18 AM, Mark Brown wrote: > On Fri, Jun 03, 2011 at 11:04:52AM -0600, Grant Likely wrote: > >> I ended up not pushing this one to Linus. ?Turns out it causes other >> breakage on other platforms that don't include include/linux/gpio.h. >> Since I don't have confidence that I'll be able to find all the >> offenders, I'm dropping it. ?I recommend making any drivers that are > > So, this originally came about because I pushed back on adding random > dependencies like this for features which are pretty much optional in > drivers - their use of GPIOs is totally optional and the dependencies > are just too fragile, leading to noise with all the randconfigs. ?It > seems better to get the architectures to keep up with enhancements to > gpiolib (or convert to it) than to have to worry about this in drivers. Fair enough. Randy, if you or someone else can check that all GPIOF_ users have the required #include , then I'm okay with this patch. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/