Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857Ab1FCSXR (ORCPT ); Fri, 3 Jun 2011 14:23:17 -0400 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:5011 "EHLO TX2EHSOBE009.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751794Ab1FCSXQ (ORCPT ); Fri, 3 Jun 2011 14:23:16 -0400 X-SpamScore: -3 X-BigFish: VS-3(zz98dKzz1202hzzz2dh2a8h668h839h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPVD:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Message-ID: <4DE92675.6080908@freescale.com> Date: Fri, 3 Jun 2011 13:22:45 -0500 From: Timur Tabi Organization: Freescale User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.19) Gecko/20110429 Fedora/3.6.17-1.fc13 Firefox/3.6.17 MIME-Version: 1.0 To: Alexey Dobriyan CC: , , , Subject: Re: [PATCH] lib: introduce strdup_from_user References: <1307119552-15573-1-git-send-email-timur@freescale.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 19 Alexey Dobriyan wrote: > NAK > It accesses userspace data twice. What's wrong with that? How else is it supposed to know how much to allocate without using strlen first? Besides, it was Alan's idea to make this a common function. I can easily put it back in my driver. -- Timur Tabi Linux kernel developer at Freescale -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/