DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=Exlbm3CW6w82SrSOoNKGtKcEB6qTZNA3ZdyR2n1rxtEFL8JfHIE1KgiIU1m/XDMzrP
         ESeK4vLpK0K7UXCvAaMSWS49exDUZ8hukOoYwdidBJGUavXPQIACQrB/4k64fdSA7DeM
         8PIPtd3hlYcFYXmHLkaR8pA6k6/IIExAXYMpw=
MIME-Version: 1.0
In-Reply-To: <4DE92AC0.1000806@freescale.com>
References: <1307119552-15573-1-git-send-email-timur@freescale.com>
	<BANLkTikFjF0WF---8A9_CBybf+bUji2smw@mail.gmail.com>
	<4DE92675.6080908@freescale.com>
	<BANLkTimB2UanZA4wf=uBGcj=wKmDhCco=w@mail.gmail.com>
	<4DE9294B.3040501@freescale.com>
	<BANLkTinqQS11nXQAJBMSvCrp4tOtCg5Qww@mail.gmail.com>
	<4DE92AC0.1000806@freescale.com>
Date: Fri, 3 Jun 2011 21:47:27 +0300
Message-ID: <BANLkTik_O2QvXqeY03NU3xP1q0=Dqco6Eg@mail.gmail.com>
Subject: Re: [PATCH] lib: introduce strdup_from_user
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Timur Tabi <timur@freescale.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
        scottwood@freescale.com, akpm@linux-foundation.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 614
Lines: 16

On Fri, Jun 3, 2011 at 9:41 PM, Timur Tabi <timur@freescale.com> wrote:
> Alexey Dobriyan wrote:
>> The point is data should cross kernelspace/userspace boundary only once.
>
> And my new version does that. ?I'm just asking if you're okay with it.

It leaks first allocation if second one fails.

Come on.

Show you user in driver, maybe what we're discussing is moot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/