Message-ID: <4DE92EA2.60705@freescale.com>
Date: Fri, 3 Jun 2011 13:57:38 -0500
From: Timur Tabi <timur@freescale.com>
Organization: Freescale
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.19) Gecko/20110429 Fedora/3.6.17-1.fc13 Firefox/3.6.17
MIME-Version: 1.0
To: Scott Wood <scottwood@freescale.com>
CC: Alexey Dobriyan <adobriyan@gmail.com>, <alan@lxorguk.ukuu.org.uk>,
        <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: introduce strdup_from_user
References: <1307119552-15573-1-git-send-email-timur@freescale.com>	<BANLkTikFjF0WF---8A9_CBybf+bUji2smw@mail.gmail.com>	<4DE92675.6080908@freescale.com>	<BANLkTimB2UanZA4wf=uBGcj=wKmDhCco=w@mail.gmail.com>	<4DE9294B.3040501@freescale.com>	<BANLkTinqQS11nXQAJBMSvCrp4tOtCg5Qww@mail.gmail.com> <20110603135303.0800e4a7@schlenkerla.am.freescale.net>
In-Reply-To: <20110603135303.0800e4a7@schlenkerla.am.freescale.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 21

Scott Wood wrote:
> Why does it matter, as long as it doesn't hurt the kernel if userspace
> plays games (i.e. take care of the NUL termination), and it's not a
> performance problem?

Ok, I don't know why I didn't notice this earlier, but this function already
exists in the kernel.  It's called strndup_user().

So I'd like to rescind this patch, please.

Note that strndup_user() has the double-access problem.

-- 
Timur Tabi
Linux kernel developer at Freescale

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/