Date: Fri, 3 Jun 2011 23:41:33 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>, Timur Tabi <timur@freescale.com>,
        alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH] lib: introduce strdup_from_user
Message-ID: <20110603224133.GQ11521@ZenIV.linux.org.uk>
References: <1307119552-15573-1-git-send-email-timur@freescale.com>
 <BANLkTikFjF0WF---8A9_CBybf+bUji2smw@mail.gmail.com>
 <4DE92675.6080908@freescale.com>
 <BANLkTimB2UanZA4wf=uBGcj=wKmDhCco=w@mail.gmail.com>
 <4DE9294B.3040501@freescale.com>
 <BANLkTinqQS11nXQAJBMSvCrp4tOtCg5Qww@mail.gmail.com>
 <20110603135303.0800e4a7@schlenkerla.am.freescale.net>
 <BANLkTikmVncMdJhK0Hi6uWeiE_S9TtdhTQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTikmVncMdJhK0Hi6uWeiE_S9TtdhTQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1277
Lines: 27

On Fri, Jun 03, 2011 at 10:12:37PM +0300, Alexey Dobriyan wrote:

> Because now you're lucky C strings are NUL-terminated.
> If this "idiom" applies to some other case like "validate + copy",
> we have a bug.
> 
> We copy data to kernelspace THEN validate or copy or whatever.
> This is obviously correct and safe.

In this case we don't know how _much_ needs to be copied, and that information
comes precisely from NUL-termination.  IOW, it's not a matter of luck at all.

"Copy the amount of bytes equal to the limit given to us, then truncate if
needed" is seriously broken in this case.  Think what happens if you have
a short string sitting in the middle of a page, with the next page not
mapped at all.  And ask to copy up to 4096 bytes.  The string itself is
much shorter than that.  However, trying to blindly copy those 4096 bytes
will give you -EFAULT.  Which is not what we want when copying strings
from userland.

We certainly do not want to *reread* them, but this "find the length, then
copy that much" is just fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/