Date: Fri, 3 Jun 2011 16:24:35 -0700
From: Andres Salomon <dilinger@queued.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5535 mfgpt - fix wrong if condition
Message-ID: <20110603162435.0e359a60@queued.net>
In-Reply-To: <20110603161415.49031357.akpm@linux-foundation.org>
References: <BANLkTimR2ggkjDiB9fZDuHJOuFX1Pb=rMw@mail.gmail.com>
	<20110603161415.49031357.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2001
Lines: 59

You're right, it's reversed.

Acked-by: Andres Salomon <dilinger@queued.net>


On Fri, 3 Jun 2011 16:14:15 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 25 May 2011 19:08:06 +0000
> Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
> 
> > From: Christian Gmeiner <christian.gmeiner@gmail.com>
> > 
> > This patch fixes the wrong if condition for the check if the
> > requested timer is available.
> > 
> > The bitmap avail is used to store if a timer is used already.
> > test_bit() is used to check if the requested timer is
> > available. If a bit in the avail bitmap is set it means that the
> > timer is available.
> > 
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > ---
> >  drivers/misc/cs5535-mfgpt.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/misc/cs5535-mfgpt.c
> > b/drivers/misc/cs5535-mfgpt.c index e01e08c..bc685bf 100644
> > --- a/drivers/misc/cs5535-mfgpt.c
> > +++ b/drivers/misc/cs5535-mfgpt.c
> > @@ -174,7 +174,7 @@ struct cs5535_mfgpt_timer
> > *cs5535_mfgpt_alloc_timer(int timer_nr, int domain)
> >                 timer_nr = t < max ? (int) t : -1;
> >         } else {
> >                 /* check if the requested timer's available */
> > -               if (test_bit(timer_nr, mfgpt->avail))
> > +               if (!test_bit(timer_nr, mfgpt->avail))
> >                         timer_nr = -1;
> >         }
> > 
> 
> What were the runtime effects of this bug?
> 

The runtime effect would be that allocating a specific timer always
fails (versus telling cs5535_mfgpt_alloc_timer to allocate the first
available timer, which works).


> (Please always include this information in the changelog when fixing
> things)
> 
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/