Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756243Ab1FFDog (ORCPT ); Sun, 5 Jun 2011 23:44:36 -0400 Received: from mail4.comsite.net ([205.238.176.238]:59085 "EHLO mail4.comsite.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755800Ab1FFDoe (ORCPT ); Sun, 5 Jun 2011 23:44:34 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=71.22.127.106; From: Milton Miller Subject: Re: [1/4] rcu: Detect uses of rcu read side in extended quiescent states To: Frederic Weisbecker Message-Id: In-Reply-To: <1307329858-14999-3-git-send-email-fweisbec@gmail.com> References: <1307329858-14999-3-git-send-email-fweisbec@gmail.com> Cc: Frederic Weisbecker , "Paul E. McKenney" , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , LKML Date: Sun, 05 Jun 2011 22:44:33 -0500 X-Originating-IP: 71.22.127.106 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 31 On Mon, 06 Jun 2011 about 03:10:55 -0000, Frederic Weisbecker wrote: > @@ -3994,8 +3995,13 @@ void lockdep_rcu_dereference(const char *file, const int line) > printk("\n===================================================\n"); > printk( "[ INFO: suspicious rcu_dereference_check() usage. ]\n"); > printk( "---------------------------------------------------\n"); > - printk("%s:%d invoked rcu_dereference_check() without protection!\n", > - file, line); > + printk("%s:%d invoked rcu_dereference_check() ", file, line); > + > + if (type == RCU_WARN_UNPROTECTED) > + printk("without protection!\n"); > + else if (type == RCU_WARN_EXT_QS) > + printk("while in RCU extended quiescent state!\n"); > + > printk("\nother info that might help us debug this:\n\n"); > printk("\nrcu_scheduler_active = %d, debug_locks = %d\n", rcu_scheduler_active, debug_locks); > lockdep_print_held_locks(curr); Can we keep the above in one printk? That way the printing is guaranteed to come out on one line. Probably the easiest way would be add char *why = "" then assign a string based on the current conditions. Do all of that before the first printk which gets the a %s added. Thanks, milton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/